Skip to content

Add support for using the /topic prefix instead of /exchange. #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2019

Conversation

alessandroniciforo
Copy link

Add support for using the /topic prefix instead of /exchange. RabbitMQ needs the /exchange prefix for publishing on an exchange, while ActiveMQ needs the /topic prefix for publishing on a topic

Alessandro Niciforo added 2 commits April 19, 2019 16:57
…Q needs the /exchange prefix for publishing on an exchange, while ActiveMQ needs the /topic prefix for publishing on a topic
@makasim
Copy link
Member

makasim commented Apr 19, 2019

This is nice. Would you add a scheme extension too? So if stomp+activemq:// scheme passed it automatically use exchange instead of the topic.

@alessandroniciforo
Copy link
Author

That's a great idea. I pushed a commit implementing it. The scheme extensions accepted are rabbitmq and activemq. If omitted, rabbitmq is the default for backward compatibility.

@makasim makasim merged commit 50a1a56 into php-enqueue:master May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants